fix message when leave workshop #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litvinets
requested changes
Jan 18, 2022
src/app/shared/store/user.state.ts
Outdated
| @@ -480,7 +481,9 @@ export class UserState { | |||
|
|
|||
| @Action(OnUpdateApplicationSuccess) | |||
| onUpdateApplicationSuccess({ dispatch }: StateContext<UserStateModel>, { payload }: OnUpdateApplicationSuccess): void { | |||
| dispatch(new ShowMessageBar({ message: 'Статус заявки успішно змінено', type: 'success' })); | |||
| console.log('OnUpdateApplicationSuccess', payload); | |||
There was a problem hiding this comment.
remove condole log please
src/app/shared/store/user.state.ts
Outdated
| dispatch(new ShowMessageBar({ message: 'Статус заявки успішно змінено', type: 'success' })); | ||
| console.log('OnUpdateApplicationSuccess', payload); | ||
|
|
||
| dispatch(new ShowMessageBar({ message: payload.status === ApplicationStatus.Left ? `Гурток успішно залишено` : 'Статус заявки успішно змінено', type: 'success' })); |
There was a problem hiding this comment.
That's correct, but I am thinking about creating an enum for different statuses?
When provider reject the application, then there is a text "Заявку успішно відхилено"
Approve -"Заявку успішно прийнято"
etc
We can confirm it with BA.
.vscode/settings.json
Outdated
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "editor.detectIndentation": false, | |||
| "editor.tabSize": 2, | |||
| "angular.enable-strict-mode-prompt": false, | |||
src/app/shared/store/user.actions.ts
Outdated
| @@ -171,7 +171,7 @@ export class OnUpdateApplicationFail { | |||
| } | |||
| export class OnUpdateApplicationSuccess { | |||
| static readonly type = '[user] update Application success'; | |||
| constructor(public payload) { } | |||
| constructor(public payload: any) { } | |||
There was a problem hiding this comment.
we don't use the typo "any", it's a bad practice. Add typo of AplicationUpdate, I believe this is the correct one.
litvinets
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change message when leave the workshop